Re: [PATCH 2/2] MIPS: TXx9: tx49xx: Move GPIO setup from .mem_setup() to .arch_init()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Aug 18, 2016 at 2:57 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:

> txx9_gpio_init() calls gpiochip_add_data(), which fails with -ENOMEM as
> it is called too early in the boot process. This causes all subsequent
> GPIO operations to fail silently (before commit 54d77198fdfbc4f0 ("gpio:
> bail out silently on NULL descriptors") it printed the error message
> "gpiod_direction_output_raw: invalid GPIO" on RBTX49[23]7).
>
> Postpone all GPIO setup to .arch_init() time to fix this.
>
> Suggested-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html