Re: [PATCH v2] pinctrl: sh-pfc: r8a7792: add VIN pin groups

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Sergei,

On Fri, Aug 5, 2016 at 10:52 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> Add VIN[0-5] pin groups to the R8A7792 PFC driver.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> ---
> The patch is against the 'devel' branch of Linus Walleij's 'linux-pinctrl.git'
> repo plus my 6 R8A7792 PFC patches  posted before (those should  be collected
> by Geert)...
>
> Changes in version 2:
> - fixed the SoC model in the changelog.

Thanks!

Reviewed-by:  Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
> ===================================================================
> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7792.c

> +/* - VIN1 ------------------------------------------------------------------- */
> +static const union vin_data vin1_data_pins = {
> +       .data24 = {
> +               /* B */
> +               RCAR_GP_PIN(5, 4), RCAR_GP_PIN(5, 5),
> +               RCAR_GP_PIN(5, 6), RCAR_GP_PIN(5, 7),
> +               RCAR_GP_PIN(5, 8), RCAR_GP_PIN(5, 9),
> +               RCAR_GP_PIN(5, 10), RCAR_GP_PIN(5, 11),
> +               /* G */
> +               RCAR_GP_PIN(5, 12), RCAR_GP_PIN(5, 13),
> +               RCAR_GP_PIN(5, 14), RCAR_GP_PIN(5, 15),
> +               RCAR_GP_PIN(8, 5), RCAR_GP_PIN(8, 6),
> +               RCAR_GP_PIN(8, 6), RCAR_GP_PIN(8, 7),

RCAR_GP_PIN(8, 7), RCAR_GP_PIN(8, 8),

> +               /* R */
> +               RCAR_GP_PIN(9, 5), RCAR_GP_PIN(9, 6),
> +               RCAR_GP_PIN(9, 7), RCAR_GP_PIN(9, 8),
> +               RCAR_GP_PIN(9, 9), RCAR_GP_PIN(9, 10),
> +               RCAR_GP_PIN(9, 11), RCAR_GP_PIN(9, 12),
> +       },
> +};

> +static const unsigned int vin1_data18_pins[] = {
> +       /* B */
> +       RCAR_GP_PIN(5, 6), RCAR_GP_PIN(5, 7),
> +       RCAR_GP_PIN(5, 8), RCAR_GP_PIN(5, 9),
> +       RCAR_GP_PIN(5, 10), RCAR_GP_PIN(5, 11),
> +       /* G */
> +       RCAR_GP_PIN(5, 14), RCAR_GP_PIN(5, 15),
> +       RCAR_GP_PIN(8, 5), RCAR_GP_PIN(8, 6),
> +       RCAR_GP_PIN(8, 6), RCAR_GP_PIN(8, 7),

RCAR_GP_PIN(8, 7), RCAR_GP_PIN(8, 8),

> +       /* R */
> +       RCAR_GP_PIN(9, 7), RCAR_GP_PIN(9, 8),
> +       RCAR_GP_PIN(9, 9), RCAR_GP_PIN(9, 10),
> +       RCAR_GP_PIN(9, 11), RCAR_GP_PIN(9, 12),
> +};

There's no need to resend. I'll fix it up when queuing in sh-pfc-for-v4.9.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html