Re: [PATCH] pinctrl: meson: Drop pinctrl_unregister for devm_ registered device

[Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>]

On Tue, Jul 26, 2016 at 02:51:58PM +0000, Wei Yongjun wrote:
> It's not necessary to unregister pin controller device registered
> with devm_pinctrl_register() and using pinctrl_unregister() leads
> to a double free.
> 
> This is detected by Coccinelle semantic patch.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@xxxxxxxxx>

Fixes: e649f7ec8c5f ("pinctrl: meson: Use devm_pinctrl_register() for
pinctrl registration")

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

> ---
>  drivers/pinctrl/meson/pinctrl-meson.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 11623c6..44e69c9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -727,13 +727,7 @@ static int meson_pinctrl_probe(struct platform_device *pdev)
>  		return PTR_ERR(pc->pcdev);
>  	}
>  
> -	ret = meson_gpiolib_register(pc);
> -	if (ret) {
> -		pinctrl_unregister(pc->pcdev);
> -		return ret;
> -	}
> -
> -	return 0;
> +	return meson_gpiolib_register(pc);
>  }
>  
>  static struct platform_driver meson_pinctrl_driver = {
> 

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html