Re: [RFC] qnap-tsx51: add new driver for leds and button support on QNAP TS-x51 series

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sat, Jun 18, 2016 at 9:18 AM, Vincent Pelletier
<plr.vincent@xxxxxxxxx> wrote:

> Just to confirm my understanding:
> - from the chip (and its module) point of view, these signals are
>   GPIOs, because they cannot presume how it is wired
> - but from the platform point of view (this specific NAS model), these
>   GPIOs are wired to leds and buttons, so they are leds and buttons
>   and not GPIOs anymore
>
> So using GPIO numbers is acceptable in such driver.

We usually model this as GPIO if it is GPIO on the SoC,
because we want to reuse the same code on several systems
using the same SoC.

But you should use GPIO descriptors, not numbers.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html