Re: [PATCH] gpio: make sure gpiod_to_irq() returns negative on NULL desc

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Jun 17, 2016 at 6:09 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 15-06-16 23:03, Linus Walleij wrote:
>>
>> commit 54d77198fdfbc4f0fe11b4252c1d9c97d51a3264
>> ("gpio: bail out silently on NULL descriptors")
>> doesn't work for gpiod_to_irq(): drivers assume that NULL
>> descriptors will give negative IRQ numbers in return.
>>
>> It has been pointed out that returning 0 is NO_IRQ and that
>> drivers should be amended to treat this as an error, but that
>> is for the longer term: now let us repair the semantics.
>>
>> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
>> Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
>
> I can confirm that this fixes the problem for me:
>
> Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Thanks, applied for fixes and pushed for linux-next.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html