Re: [PATCH] pinctrl: at91-pio4: fix non-exported functions

[Ludovic Desroches <ludovic.desroches@xxxxxxxxx>]

On Tue, Jun 07, 2016 at 06:07:45PM +0100, Ben Dooks wrote:
> The atmel_pctl_find_group_by_pin() and the atmel_pinctrl_remove()
> functions are not exported, so fix the warnings about these
> being exported without definitions by making them static.
> 
> drivers/pinctrl/pinctrl-at91-pio4.c:424:20: warning: symbol 'atmel_pctl_find_group_by_pin' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-at91-pio4.c:1077:5: warning: symbol 'atmel_pinctrl_remove' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx

Thanks for fixing this. It conflicts with 'pinctrl: make non-modular
drivers really non modular' patches because of atmel_pinctrl_remove
removal.

Acked-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>

> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index a025b40..22c6ad0 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -421,8 +421,8 @@ static int atmel_pctl_get_group_pins(struct pinctrl_dev *pctldev,
>  	return 0;
>  }
>  
> -struct atmel_group *atmel_pctl_find_group_by_pin(struct pinctrl_dev *pctldev,
> -						 unsigned pin)
> +static struct atmel_group *
> +atmel_pctl_find_group_by_pin(struct pinctrl_dev *pctldev, unsigned pin)
>  {
>  	struct atmel_pioctrl *atmel_pioctrl = pinctrl_dev_get_drvdata(pctldev);
>  	int i;
> @@ -1074,7 +1074,7 @@ clk_prepare_enable_error:
>  	return ret;
>  }
>  
> -int atmel_pinctrl_remove(struct platform_device *pdev)
> +static int atmel_pinctrl_remove(struct platform_device *pdev)
>  {
>  	struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev);
>  
> -- 
> 2.8.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html