Re: [PATCH] gpio: bcm-kona: fix bcm_kona_gpio_reset() warnings

[Markus Mayer <markus.mayer@xxxxxxxxxxxx>]

On 7 June 2016 at 09:22, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
> The bcm_kona_gpio_reset() calls bcm_kona_gpio_write_lock_regs()
> with what looks like the wrong parameter. The write_lock_regs
> function takes a pointer to the registers, not the bcm_kona_gpio
> structure.
>
> Fix the warning, and probably bug by changing the function to
> pass reg_base instead of kona_gpio, fixing the following warning:
>
> drivers/gpio/gpio-bcm-kona.c:550:47: warning: incorrect type in argument 1 (different address spaces)
> drivers/gpio/gpio-bcm-kona.c:550:47:    expected void [noderef] <asn:2>*reg_base
> drivers/gpio/gpio-bcm-kona.c:550:47:    got struct bcm_kona_gpio *kona_gpio
> drivers/gpio/gpio-bcm-kona.c:554:47: warning: incorrect type in argument 1 (different address spaces)
> drivers/gpio/gpio-bcm-kona.c:554:47:    expected void [noderef] <asn:2>*reg_base
> drivers/gpio/gpio-bcm-kona.c:554:47:    got struct bcm_kona_gpio *kona_gpio
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> Cc: Markus Mayer <mmayer@xxxxxxxxxxxx>
> Cc: Ray Jui <rjui@xxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
>  drivers/gpio/gpio-bcm-kona.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index 9aabc48..953e4b8 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -547,11 +547,11 @@ static void bcm_kona_gpio_reset(struct bcm_kona_gpio *kona_gpio)
>         /* disable interrupts and clear status */
>         for (i = 0; i < kona_gpio->num_bank; i++) {
>                 /* Unlock the entire bank first */
> -               bcm_kona_gpio_write_lock_regs(kona_gpio, i, UNLOCK_CODE);
> +               bcm_kona_gpio_write_lock_regs(reg_base, i, UNLOCK_CODE);
>                 writel(0xffffffff, reg_base + GPIO_INT_MASK(i));
>                 writel(0xffffffff, reg_base + GPIO_INT_STATUS(i));
>                 /* Now re-lock the bank */
> -               bcm_kona_gpio_write_lock_regs(kona_gpio, i, LOCK_CODE);
> +               bcm_kona_gpio_write_lock_regs(reg_base, i, LOCK_CODE);
>         }
>  }
>
> --
> 2.8.1
>

Looks good. Thanks for fixing this.

Reviewed-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html