On 7.6.2016 04:43, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_ZYNQ > bool "Pinctrl driver for Xilinx Zynq" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Michal Simek <michal.simek@xxxxxxxxxx> > Cc: "Sören Brinkmann" <soren.brinkmann@xxxxxxxxxx> > Cc: linux-gpio@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > --- > drivers/pinctrl/pinctrl-zynq.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > index 8fdc60c5aeaf..7afdbede6823 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -20,7 +20,7 @@ > */ > #include <linux/io.h> > #include <linux/mfd/syscon.h> > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/pinctrl/pinctrl.h> > @@ -1210,7 +1210,6 @@ static const struct of_device_id zynq_pinctrl_of_match[] = { > { .compatible = "xlnx,pinctrl-zynq" }, > { } > }; > -MODULE_DEVICE_TABLE(of, zynq_pinctrl_of_match); > > static struct platform_driver zynq_pinctrl_driver = { > .driver = { > @@ -1225,13 +1224,3 @@ static int __init zynq_pinctrl_init(void) > return platform_driver_register(&zynq_pinctrl_driver); > } > arch_initcall(zynq_pinctrl_init); > - > -static void __exit zynq_pinctrl_exit(void) > -{ > - platform_driver_unregister(&zynq_pinctrl_driver); > -} > -module_exit(zynq_pinctrl_exit); > - > -MODULE_AUTHOR("Sören Brinkmann <soren.brinkmann@xxxxxxxxxx>"); > -MODULE_DESCRIPTION("Xilinx Zynq pinctrl driver"); > -MODULE_LICENSE("GPL"); > Acked-by: Michal Simek <michal.simek@xxxxxxxxxx> Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html