Re: NULL pointer dereference when 'rmmod gpio_lynxpoint'

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, May 12, 2016 at 12:34 PM, Mathias Nyman
<mathias.nyman@xxxxxxxxxxxxxxx> wrote:

> As driver was written with the original assumption of not being a module,
> there
> might be that the remove codepaths in gpio-lynxopoint are not properly
> calling
> gpiochip_remove (that should call gpiochip_irqchip_remove etc) on driver
> unload,
> or not checking if those return errors, or ourself not returning proper
> errors on removes that should fail.

We have devm_gpiochip_add_data() these days, so you don't need
to call gpiochip_remove() explicitly if you use that.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html