Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Mon, Mar 28, 2016 at 04:29:35PM +0300, Cristina Ciocan wrote:
> +/* SCORE pins */
> +static const struct pinctrl_pin_desc byt_score_pins[] = {
> +	PINCTRL_PIN(0, "SATA_GP[0]"),		/* GPIOC_0 */
> +	PINCTRL_PIN(1, "SATA_GP[1]"),		/* GPIOC_1 */

Maybe we should call these "SATA_GP0" and "SATA_GP1" like we do in other
Intel pinctrl drivers?

Also I don't think /* GPIOC_1 */ is really useful comment as that can be
derived already from the pin number.

Otherwise this looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html