Re: [PATCH] gpio: pca953x: Use correct u16 value for register word write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29/03/2016 10:39 PM, Alexander Stein wrote:
You missed CC'ing Phil (Added for this post)

On Tuesday 29 March 2016 20:53:58, Yong Li wrote:
Thanks for your comment, I think I can change it to val[0] | (val[1]
<< 8), is it okay ?

Mh, currently there is only one caller (device_pca953x_init) which passes only
0, 0 or 0xff, 0xff, so endianess is irrelevant. But to be future proof this
should be done in an endian-safe manner. Though cpu_to_le16p does not work,
due to same alignment problem as casting to u16*.


I think get_unaligned((u16 *) val) should do the job.
There's also get_unaligned_le* get_unaligned_be*

--
Regards
Phil Reid

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux