On Wed, Mar 23, 2016 at 8:49 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote: > i2c_smbus_write_byte_data() can fail. To ensure the cached buffer has > consistent status with h/w status, don't update the cached gpio->buffer > if write fails. > Also refactor the code a bit by adding a tpic2810_set_mask_bits() helper > and use it to simplify the code. Looks pretty good! Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFT] gpio: tpic2810: Make sure cached buffer has consistent status with h/w status
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH RFT] gpio: tpic2810: Make sure cached buffer has consistent status with h/w status
- From: Alexandre Courbot <gnurou@xxxxxxxxx>
- Date: Mon, 28 Mar 2016 12:30:40 +0900
- In-reply-to: <1458733781.22226.3.camel@ingics.com>
- References:
- Prev by Date: Re: Problems with commit a770d946371e ("gpio: pxa: add pin control gpio direction and request")
- Next by Date: arm:collie_defconfig broken since commit ff2b135922 ("gpio: make the gpiochip a real device")
- Previous by thread: [PATCH RFT] gpio: tpic2810: Make sure cached buffer has consistent status with h/w status
- Next by thread: Re: [PATCH RFT] gpio: tpic2810: Make sure cached buffer has consistent status with h/w status
- Index(es):
 |