RE: [PATCH 1/3] pinctrl: Intel: add RX invertion config

["Zheng, Qi" <qi.zheng@xxxxxxxxx>]

BRs


On Mon, Mar 14, 2016 at 03:10:07AM +0200, Zheng, Qi wrote:
> On Sat, Mar 12, 2016 at 01:06:00AM +0800, Qipeng Zha wrote:
> > Some module need to enable RX invertion config on BXT platform.
> > 
> > Signed-off-by: Qi Zheng <qi.zheng@xxxxxxxxx>
> > Signed-off-by: Qipeng Zha <qipeng.zha@xxxxxxxxx>
> 
> > Can I ask what module might need this? I'm not so certain we want to add anything like this to the driver to be honest.
> 
> The "pi330532" device on Broxton requires this function to manually trigger an GPIO input interrupt.
>
> That is to say, actually no signal change on the pin but toggling this 
> RX inversion bit to make the GPIO controller believes there is voltage 
> change on the pin thus triggering the interrupt.

> That sounds rather hackish thing and definitely should not be part of the driver IMHO.

> I'm pretty sure there are better ways to do what you are doing.
We have gone through this requirement from CHT to BXT, there was no other better way to simulate the GPIO interrupt for the use of those devices.
If you insist it is not OK,  I am fine to keep it on Intel local branch.
Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html