Re: [PATCH] pinctrl: rockchip: add support the get_direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2016年03月14日 13:44, Caesar Wang 写道:
This patch adds the get_direction to support the gpio
interface.

the gpio direction is not used on rockchip platform when use the gpio
debugfs.

Tested on kylin board. (RK3036 SoCs)
The repro steps:
$/sys/class/gpio/
echo 53 > export
$/sys/class/gpio/gpio53# cat direction
in
In general, the gpio53 should be out value, but the direction is the
default value 'in',  since the get_direction didn't supported in rockchip
pinctrl.

So, we should add this patch to support it.

Change-Id: I237c2e85ac7680b3d0de15bbbb923985b4827def

Resend it since the change id, sorry for the noise.

Reported-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Heiko Stuebner <heiko@xxxxxxxxx>
Cc: linux-gpio@xxxxxxxxxxxxxxx
Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
---
  drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index bf032b9..f22a186 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1208,6 +1208,18 @@ static int rockchip_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
  	return 0;
  }
+static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+{
+	struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
+	int pin;
+	u32 data;
+
+	pin = offset - chip->base;
+	data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
+
+	return !!(data & BIT(pin));
+}
+
  /*
   * The calls to gpio_direction_output() and gpio_direction_input()
   * leads to this function call (via the pinctrl_gpio_direction_{input|output}()
@@ -1741,6 +1753,7 @@ static const struct gpio_chip rockchip_gpiolib_chip = {
  	.free = gpiochip_generic_free,
  	.set = rockchip_gpio_set,
  	.get = rockchip_gpio_get,
+	.get_direction	= rockchip_gpio_get_direction,
  	.direction_input = rockchip_gpio_direction_input,
  	.direction_output = rockchip_gpio_direction_output,
  	.to_irq = rockchip_gpio_to_irq,

--
caesar wang | software engineer | wxt@xxxxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux