[PATCH] gpio: gpio-pca953x: no interrupts with 4-bit devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I/O expanders with less than 8 I/O (PCA9536 and PCA9537, currently) fail to invoke interrupt handlers because the NBANK macro

    #define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
incorrectly calculates no banks for these devices. As a result, pca953x_irq_pending() never sets the trigger_seen flag.

The patch below fixed the issue by changing the NBANK() macro.

Signed-off-by: Frank Edelhaeuser <mrpace2 <at> gmail.com>
---
diff -Nur a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
--- a/drivers/gpio/gpio-pca953x.c 2016-03-08 00:00:00.000000000 +0000
+++ b/drivers/gpio/gpio-pca953x.c 2016-03-08 00:00:00.000000000 +0000
@@ -86,7 +86,7 @@
 #define MAX_BANK 5
 #define BANK_SZ 8

-#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
+#define NBANK(chip) (((chip->gpio_chip.ngpio - 1) / BANK_SZ) + 1)

 struct pca953x_chip {
  unsigned gpio_start;

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux