Re: [PATCH 0/3] OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag

[Grygorii Strashko <grygorii.strashko@xxxxxx>]

On 02/15/2016 10:27 PM, Tony Lindgren wrote:
> * Sudeep Holla <sudeep.holla@xxxxxxx> [160215 02:03]:
>> Hi Linus,
>>
>> On 13/02/16 14:42, Linus Walleij wrote:
>>> On Mon, Feb 1, 2016 at 7:28 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>>>
>>>>    pinctrl: single: Use a separate lockdep class
>>>>    pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag
>>>>    ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag
>>>>
>>>>   arch/arm/mach-omap2/mux.c        |  4 ++--
>>>>   arch/arm/mach-omap2/pm34xx.c     |  9 ++++-----
>>>>   arch/arm/mach-omap2/prm_common.c |  1 +
>>>>   drivers/pinctrl/pinctrl-single.c | 15 ++++++++++++---
>>>
>>> Are these patches orthogonal so I can merge the pinctrl patch independently
>>> of the OMAP patches if Tony ACKs this?
>>>
>>
>> Thanks for the follow up.
>> IIUC they are dependent and remember Tony/Grygorii wanted them to be
>> merged together(at-least for bisectibility)
> 
> AFAIK this series needs to be kept together to keep things
> working.
> 
>>> If not: should it be merged by me or through ARM SoC/Tony?
>>>
>>
>> I think so.
>>
>>> Anyways waiting for maintainer feedback, but the above is good to know.
>>>
>>
>> Grygorii was still not sure if this works and he couldn't give it a
>> test. He was traveling and may need more time to get back on this.
> 
> He said it does not work so clearly more work is needed.
> 

Yeah. As I mentioned before patches 2/3 will not work.
I've tried to test suspend with diff I posted [1], but I did it only on 
dra7 and am43 where suspend i more simple than on omap3. Also, I worry
that with such approach some irq can be missed (especially edge ones), 
because PRCM irqs will be re-enabled at very late resume stage 
(right before thaw).

Second option, I see, is to rework PRCM to be threaded IRQ, but in this case
all children IRQs will need to be threaded/nested threaded
(including PCS, legacy OMAP mux, OMAP3 _prcm_int_handle_wakeup/_prcm_int_handle_io).

Are there any objection to convert PCS to threaded IRQ, for example? ;)
 

[1] https://patchwork.ozlabs.org/patch/578915/

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html