On 02/29/2016 06:30 PM, Eric Anholt wrote:
From: Phil Elwell <phil@xxxxxxxxxxxxxxx> The DT bindings for pinctrl-bcm2835 allow both the function and pull to contain either one entry or one per pin. However, an error in the DT parsing can cause failures if the number of pulls differs from the number of functions. Signed-off-by: Eric Anholt <eric@xxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx --- Yes, the s-o-b differs from the author of the commit, but this falls under part b) of the process.
I'd argue that part (b) only applies if the s-o-b line is present in the original, otherwise I'm not sure how it's clear the author intended to publish their source under the license in question. That's why I've always beedn careful to go back and ask the original author to give their s-o-b, like you did. Some commits at least in the earlier Pi Foundation kernels also clearly had incorrect git author values, or were squashed together forms of multiple peoples' work:-(
Luckily it's a moot point since Phil gave his s-o-b. Reviewed-by: Stephen Warren <swarren@xxxxxxxxxxxxx> Does a similar bug exist in any other pinctrl drivers? -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
