Re: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields

[Julien Grossholtz <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>]

Hello,

Thank you for this patch. I checked and it still works as expected.

----- Original Message -----
> From: "Axel Lin" <axel.lin@xxxxxxxxxx>
> To: "Linus Walleij" <linus.walleij@xxxxxxxxxx>
> Cc: "Julien Grossholtz" <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>, "Alexandre Courbot" <gnurou@xxxxxxxxx>,
> linux-gpio@xxxxxxxxxxxxxxx
> Sent: Saturday, February 20, 2016 1:22:46 AM
> Subject: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields

> Both chip->base and chip->label are correctly set by bgpio_init().
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
Tested-by: Julien Grossholtz <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-ts4800.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
> index 9da79e4..1478245 100644
> --- a/drivers/gpio/gpio-ts4800.c
> +++ b/drivers/gpio/gpio-ts4800.c
> @@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
> 		return retval;
> 	}
> 
> -	chip->base = -1;
> -	chip->label = dev_name(&pdev->dev);
> 	chip->ngpio = ngpios;
> 
> 	platform_set_drvdata(pdev, chip);
> --
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html