Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

Add device managed APIs devm_gpiochip_add_data() and
devm_gpiochip_remove() for the APIs gpiochip_add_data()
and gpiochip_remove().

This helps in reducing code in error path and sometimes
removal of .remove callback for driver unbind.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
I like the looks of this.

One comment: you must also patch
Documentation/driver-model/devres.txt

Sure,


Will you also follow up with a massive patch set making use of
this new API? I feel bad about merging an API if it's not used.

Thanks for only supporting this for the new _data() function.


Yes, I have planned for this to use this new API. This is just for getting review whether fine or not to have devm_* APIs so that I can make changes on rest of driver to use this new APIs.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux