On Mon, Feb 15, 2016 at 10:14 AM, Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> wrote: > At first view I thought this function returned an error, but actually > it is the input direction. Use the define for input which makes reading > the code much easier. > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> NACK that flag is for consumers, not drivers. Drivers have their own API and should ideally return a bool true/false, but that would be another major refactoring.... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Tue, 16 Feb 2016 15:55:47 +0100
- In-reply-to: <1455527640-10446-1-git-send-email-alexander.stein@systec-electronic.com>
- Follow-Ups:
- Re: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- From: Alexander Stein
- Re: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- References:
- [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- From: Alexander Stein
- [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- Prev by Date: Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support
- Next by Date: Re: [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level
- Previous by thread: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- Next by thread: Re: [PATCH 1/1] gpio: pisosr: Don't use magic numbers
- Index(es):
 |