Re: [PATCH] pinctrl: intel: Turn Baytrail support to tristate

[Jean Delvare <jdelvare@xxxxxxx>]

Hi Mika, Linus,

On Tue, 16 Feb 2016 10:53:46 +0200, Mika Westerberg wrote:
> On Tue, Feb 16, 2016 at 12:13:36AM +0100, Linus Walleij wrote:
> > On Thu, Feb 11, 2016 at 12:23 PM, Mika Westerberg
> > <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > > On Thu, Feb 11, 2016 at 12:05:51PM +0100, Jean Delvare wrote:
> > >> The pinctrl-baytrail driver builds just fine as a module so give
> > >> users this option.
> > >
> > > IIRC the reason why this is built-in is that there are all kind of ACPI
> > > GPIO magic happening behind the scenes on Baytrail-T based machines
> > > (such as Asus T100) and it does not work without the GPIO driver. Some
> > > of the stuff is done pretty early too.
> > 
> > Hm I wonder if that could be the case for the AMD driver that just
> > got tristated too...
> 
> If they use ACPI GPIO events and operation regions early at boot then it
> can be the case.

TBH my patches were more RFCs or even wishful thinking than real
patches. Sorry for not being clearer about this.

Hardware-specific code which can only be built-in is a problem, because
it doesn't scale in the long run, so the pinctrl-baytrail and
pinctrl-amd drivers as they exist today do not please me. Same for
acpi_lpss and acpi_apd, btw... Hardware-specific code that is always
built-in. If we keep doing that then distribution kernels will just
grow and grow beyond reason.

So if there is any way to let this code be modularized, that would be
great. At this point I still did not see the explanation as to why it
can't be done. "All kind of ACPI GPIO magic happening behind the
scenes" is not an explanation, that's something I would expect from the
marketing department, not engineering ;-) I'd like to know what exactly
is being done, how and why it technically can't be done after loading a
module, it that's actually the case.

Thanks,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html