Re: [PATCH] gpio/pinctrl: sunxi: stop poking around in private vars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

On Thu, Feb 11, 2016 at 08:29:03PM +0100, Linus Walleij wrote:
> This kind of hacks disturbs the refactoring of the gpiolib.
> 
> The descriptor table belongs to the gpiolib, if we want to know
> something about something in it, use or define the proper accessor
> functions. Let's add this gpiochip_lins_is_irq() to do what the
> sunxi driver is trying at so we can privatize the descriptors
> properly.
> 
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

It looks ok.

Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux