Re: [PATCH RFT] gpio: ts4800: Fixup flags argument for bgpio_init

[Julien Grossholtz <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>]

Hi Alex,


----- Original Message -----
> From: "Axel Lin" <axel.lin@xxxxxxxxxx>
> To: "Linus Walleij" <linus.walleij@xxxxxxxxxx>
> Cc: "Julien Grossholtz" <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>, "Alexandre Courbot" <gnurou@xxxxxxxxx>,
> linux-gpio@xxxxxxxxxxxxxxx
> Sent: Thursday, February 11, 2016 11:16:30 PM
> Subject: [PATCH RFT] gpio: ts4800: Fixup flags argument for bgpio_init

> BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER is 0.
> Fixup the trivial typo.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> Hi Julien,
> I don't have this h/w, can you review and test if this patch works.

No, this patch is not working. The big endian flags where a mistake.
Therefore I submitted a patch to remove them:
[PATCH v2] gpio: TS-4800: remove useless bgpio_init flags. 

There is no flag required at all for bgpio_init,
I ran my tests and it worked as expected.

Thank you for proposing a solution.



> Thanks,
> Axel
> 
> drivers/gpio/gpio-ts4800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
> index c4908a4..c244c31 100644
> --- a/drivers/gpio/gpio-ts4800.c
> +++ b/drivers/gpio/gpio-ts4800.c
> @@ -49,7 +49,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
> 	retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
> 			    base_addr + OUTPUT_REG_OFFSET, NULL,
> 			    base_addr + DIRECTION_REG_OFFSET, NULL,
> -			    BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
> +			    BGPIOF_BIG_ENDIAN | BGPIOF_BIG_ENDIAN_BYTE_ORDER);
> 	if (retval) {
> 		dev_err(&pdev->dev, "bgpio_init failed\n");
> 		return retval;
> --
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html