Re: [PATCH v2 1/2] dt-bindings: GPIO: Add generic serializer binding

[Rob Herring <robh@xxxxxxxxxx>]

On Mon, Jan 25, 2016 at 10:37:30AM -0600, Andrew F. Davis wrote:
> Add binding for generic parallel-in/serial-out shift register devices
> used as GPIO.
> 
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> ---
>  .../devicetree/bindings/gpio/gpio-pisosr.txt       | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-pisosr.txt

One nit, otherwise:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pisosr.txt b/Documentation/devicetree/bindings/gpio/gpio-pisosr.txt
> new file mode 100644
> index 0000000..e69e8ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pisosr.txt
> @@ -0,0 +1,34 @@
> +Generic Parallel-in/Serial-out Shift Register GPIO Driver
> +
> +This binding describes generic parallel-in/serial-out shift register
> +devices that can be used for GPI (General Purpose Input). This includes
> +SN74165 serial-out shift registers and the SN65HVS88x series of
> +industrial serializers.
> +
> +Required properties:
> + - compatible		: Should be "pisosr-gpio".
> + - gpio-controller	: Marks the device node as a GPIO controller.
> + - #gpio-cells		: Should be two. For consumer use see gpio.txt.
> +
> +Optional properties:
> + - ngpios		: Number of GPIO lines, default is 8.
> + - load-gpios		: GPIO pin specifier attached to load enable, this
> +			  pin is pulsed before reading from the device to
> +			  load input pin values into the the device.
> +
> +For other required and optional properties of SPI slave
> +nodes please refer to ../spi/spi-bus.txt.
> +
> +Example:
> +
> +	sn65hvs882@0 {

should be gpio@0

> +		compatible = "pisosr-gpio";
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +
> +		load-gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
> +
> +		reg = <0>;
> +		spi-max-frequency = <1000000>;
> +		spi-cpol;
> +	};
> -- 
> 2.7.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html