Re: [PATCH v6 4/9] gpio: aggregator: introduce basic configfs interface

[Koichiro Den <koichiro.den@xxxxxxxxxxxxx>]

On Thu, Mar 20, 2025 at 04:54:26PM GMT, Bartosz Golaszewski wrote:
> On Sat, Mar 15, 2025 at 5:41 PM Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
> >
> > ---(snip)---
> >
> > Signed-off-by: Koichiro Den <koichiro.den@xxxxxxxxxxxxx>
> > ---
> >
> > @@ -90,6 +124,70 @@ static int aggr_add_gpio(struct gpio_aggregator *aggr, const char *key,
> >         return 0;
> >  }
> >
> > +static bool aggr_is_active(struct gpio_aggregator *aggr)
> 
> Series-wide: I would prefer a different prefix: why not
> gpio_aggregator or at least gpio_aggr?

Actually, that naming was intentional, but perhaps I could say this is just my
personal preference. Here is a breakdown of the function name prefixes:

  Before this patch series:
  * forwarder:        gpiochip_fwd_* + gpio_fwd_*
  * sysfs interface:  new_device/delete_device + aggr_*
  * platform device:  gpio_aggregator_*
  * module init/exit: gpio_aggregator_*

  After this patch series:
  * common utils:     aggr_*
  * forwarder:        gpiochip_fwd_* + gpio_fwd_*  <-- _Unchanged_
  * configfs:         gpio_aggr_*
  * sysfs interface:  new_device/delete_device     <-- _Unchanged_
  * platform device:  gpio_aggregator_*            <-- _Unchanged_
  * module init/exit: gpio_aggregator_*            <-- _Unchanged_

Do you still see the need to change as you suggested and send v7?

Koichiro

> 
> Other than that, looks good to me!
> 
> Bartosz