> In atmel_pctl_dt_subnode_to_map(), the return value of > pinctrl_utils_add_map_mux() needs to be checked, for the function > will fail to associate group when the group map is full. … Please improve such a change description another bit. > propagate the error code to caller function when the function fails. call failed? How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc7#n145 Regards, Markus