On Thu, Mar 20, 2025 at 09:35:15AM +0100, Mathieu Dubois-Briand wrote: > On Wed Mar 19, 2025 at 8:15 AM CET, Michael Walle wrote: ... > > Also, what is the advantage of this? Your caller doesn't have to > > call devm_regmap_add_irq_chip_fwnode(), but on the flip side you > > have to cram all its parameters in the gpio_regmap config. I'd like > > to keep that small and simple (but still extensible!). IMHO just > > setting the irq_domain is enough to achieve that. > > This was a request from Andy on my previous series. The benefit is deduplication of a lot of code. You may consider it the same as GPIO library does with IRQ chip. This is just the same on a different level. Besides the driver in this series, I would think of other GPIO drivers that are not (yet) converted to regmap (partially because of this is being absent) or existing drivers, if any, that may utilise it. -- With Best Regards, Andy Shevchenko