Re: [PATCH v3] pinctrl: spacemit: enable config option

[Alex Elder <elder@xxxxxxxxxxxx>]

On 3/17/25 3:18 AM, Geert Uytterhoeven wrote:
> Hi Yixun,
>
> Thanks for your patch, which is now commit 7ff4faba63571c51
> ("pinctrl: spacemit: enable config option") in v6.14-rc7.
>
> On Tue, 18 Feb 2025 at 01:32, Yixun Lan <dlan@xxxxxxxxxx> wrote:
> > Pinctrl is an essential driver for SpacemiT's SoC,
> > The uart driver requires it, same as sd card driver,
> > so let's enable it by default for this SoC.
> >
> > The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> > 'make defconfig' to select kernel configuration options.
> > This result in a broken uart driver where fail at probe()
> > stage due to no pins found.
>
> Perhaps this is an issue with the uart driver?
> I just disabled CONFIG_PINCTRL_RZA2 on RZA2MEVB (which is one of the
> few Renesas platforms where the pin control driver is not enabled by
> default, for saving memory), and the system booted fine into a Debian
> nfsroot.  Probe order of some devices did change, and "Trying to
> probe devices needed for running init" was printed.
>
> > Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
> > Reported-by: Alex Elder <elder@xxxxxxxxxx>
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > Tested-by: Alex Elder <elder@xxxxxxxxxxxx>
> > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
>
> > --- a/drivers/pinctrl/spacemit/Kconfig
> > +++ b/drivers/pinctrl/spacemit/Kconfig
> > @@ -4,9 +4,10 @@
> >   #
> >
> >   config PINCTRL_SPACEMIT_K1
> > -       tristate "SpacemiT K1 SoC Pinctrl driver"
> > +       bool "SpacemiT K1 SoC Pinctrl driver"
> >          depends on ARCH_SPACEMIT || COMPILE_TEST
> >          depends on OF
> > +       default y
>
> Ouch, fix sent...
> "[PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to
> y unconditionally"
> https://lore.kernel.org/6881b8d1ad74ac780af8a974e604b5ef3f5d4aad.1742198691.git.geert+renesas@xxxxxxxxx

This is interesting; what you say was what was proposed in v1
of the patch series.

I did not understand COMPILE_TEST to be used the way you say,
but I think that just means you understood it better than I do.

I think the rule is that "depends on FOO || COMPILE_TEST" alone
is fine.  But if you are going to specify a default, it should
be "default FOO" and not "default y".

Thanks for pointing this out.  I'll go respond to your patch.

					-Alex

> >          select GENERIC_PINCTRL_GROUPS
> >          select GENERIC_PINMUX_FUNCTIONS
> >          select GENERIC_PINCONF
>
> Gr{oetje,eeting}s,
>
>                          Geert