From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> On Tue, 11 Mar 2025 18:56:31 +0100, Bartosz Golaszewski wrote: > During chip registration we should neither check the return value of > gc->get_direction() nor hold the SRCU lock when calling it. The former > is because pin controllers may have pins set to alternate functions and > return errors from their get_direction() callbacks. That's alright - we > should default to the safe INPUT state and not bail-out. The latter is > not needed because we haven't registered the chip yet so there's nothing > to protect against dynamic removal. In fact: we currently hit a lockdep > splat. Revert to calling the gc->get_direction() callback directly and > *not* checking its value. > > [...] Applied, thanks! [1/1] gpiolib: don't check the retval of get_direction() when registering a chip commit: 0102fbf52b93e609fec0dab53b1fb4fe69113f5e Best regards, -- Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>