On Tue, Mar 11, 2025 at 11:23:12AM +0000, Sudeep Holla wrote: > On Tue, Mar 11, 2025 at 11:12:45AM +0000, Peng Fan wrote: > > > > So it is clear that wrong fw_devlink is created, it is because scmi cpufreq device is > > created earlier and when device_add, the below logic makes the fwnode pointer points > > to scmi cpufreq device. > > if (dev->fwnode && !dev->fwnode->dev) { > > dev->fwnode->dev = dev; > > fw_devlink_link_device(dev); > > } > > > > Thanks, looks like simple way to reproduce the issue. I will give it a try. > I could reproduce but none of my solution solved the problem completely or properly. And I don't like the DT proposal you came up with. I am not inclined to just drop this fwnode setting in the scmi devices and just use of_node. -- Regards, Sudeep