Re: [PATCH 04/15] gpio: bd71828: use new line value setter callbacks

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Mon, Mar 10, 2025 at 2:20 PM Matti Vaittinen
<mazziesaccount@xxxxxxxxx> wrote:
>
> > @@ -28,12 +27,10 @@ static void bd71828_gpio_set(struct gpio_chip *chip, unsigned int offset,
> >        * we are dealing with - then we are done
> >        */
> >       if (offset == HALL_GPIO_OFFSET)
> > -             return;
> > +             return 0;
>
> Should this be -EINVAL (or, can this check be just dropped?) Value of an
> input pin is tried to be set.
>

I don't want to break existing users but I did notice that and figured
that we should rather check this in core GPIO code not each individual
driver.

I put that on my TODO list.

Bart