Re: [PATCH 1/2] irqdomain: support three-cell scheme interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus Walleij:

On 09:44 Fri 28 Feb     , Linus Walleij wrote:
> On Thu, Feb 27, 2025 at 9:42 PM Yixun Lan <dlan@xxxxxxxxxx> wrote:
> 
> > > This function is meant for "twocell".  There is also another function
> > > irq_domain_translate_onecell().  Why don't you just create
> > > irq_domain_translate_threecell" instead?
> > >
> > good question!
> >
> > it's too many changes for adding "threecell" which I thought not worth
> > the effort, or maybe we can rename the function to *twothreecell()?
> >
> > I'm not sure which way to go is the best, ideas from maintainer are
> > welcome
> 
> Yeah just rename it twothreecell, that's fine, we will understand it :)
> 
there will be quite a lot files to touch, which looks a little bit scary
but anyway, I'm fine with either way..

$ git grep irq_domain_translate_twocell | cut -f 1 -d ':' | sort -u | wc -l
11

Thomas Gleixner, do you agree with this direction? then I can work on it

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux