Re: [PATCH v3 2/2] gpio: vf610: Switch to gpio-mmio

[Johan Korsnes <johan.korsnes@xxxxxxxxxxxxx>]

On 2/19/25 10:04 PM, Linus Walleij wrote:
> After adding a pinctrl flag to gpio-mmio we can use it
> for driving gpio-vf610.
> 
> The existing code has the same semantics and the generic
> gpio-mmio, including reading from the data out register
> when the direction is set to input, and it can also handle
> the absence of the direction register better than the
> current driver: we get the direction from the shadow
> direction registers in gpio-mmio instead.
> 
> Since gpio-mmio has an internal spinlock we can drop the
> direction-protecting spinlock from the driver.
> 

Hi,

Could the following headers be dropped?

#include <linux/pinctrl/consumer.h>
#include <linux/spinlock.h>

Kind regards,
Johan