Re: [PATCH v2 3/3] pinctrl: samsung: add support for exynos7870 pinctrl

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Wed, Feb 19, 2025 at 12:18:59AM +0530, Kaustabh Chakraborty wrote:
 +
> +/* pin banks of exynos7870 pin-controller 2 (ESE) */
> +static const struct samsung_pin_bank_data exynos7870_pin_banks2[] __initconst = {
> +	EXYNOS7870_PIN_BANK_EINTG(5, 0x000, "gpc7", 0x00),
> +};
> +
> +/* pin banks of exynos7870 pin-controller 3 (FSYS) */
> +static const struct samsung_pin_bank_data exynos7870_pin_banks3[] __initconst = {
> +	EXYNOS7870_PIN_BANK_EINTG(3, 0x000, "gpr0", 0x00),
> +	EXYNOS7870_PIN_BANK_EINTG(8, 0x020, "gpr1", 0x04),
> +	EXYNOS7870_PIN_BANK_EINTG(2, 0x040, "gpr2", 0x08),
> +	EXYNOS7870_PIN_BANK_EINTG(4, 0x060, "gpr3", 0x0c),
> +	EXYNOS7870_PIN_BANK_EINTG(6, 0x080, "gpr4", 0x10),
> +};
> +
> +/* pin banks of exynos7870 pin-controller 4 (MIF) */
> +static const struct samsung_pin_bank_data exynos7870_pin_banks4[] __initconst = {
> +	EXYNOS7870_PIN_BANK_EINTG(2, 0x000, "gpm0", 0x00),
> +};
> +
> +/* pin banks of exynos7870 pin-controller 5 (NFC) */
> +static const struct samsung_pin_bank_data exynos7870_pin_banks5[] __initconst = {
> +	EXYNOS7870_PIN_BANK_EINTG(4, 0x000, "gpc2", 0x00),
> +};
> +
> +/* pin banks of exynos7870 pin-controller 6 (TOP) */
> +static const struct samsung_pin_bank_data exynos7870_pin_banks6[] __initconst = {
> +	EXYNOS7870_PIN_BANK_EINTG(4, 0x000, "gpb0", 0x00),

Why do you need this new macro? Isn't this the same as existing
exynos8895? Maybe just rename exynos8895 driver bits/structs/types into
7870?

Best regards,
Krzysztof