Re: [PATCH v3 01/13] gpio: aggregator: reorder functions to prepare for configfs introduction

[Koichiro Den <koichiro.den@xxxxxxxxxxxxx>]

On Mon, Feb 17, 2025 at 02:07:53PM GMT, Geert Uytterhoeven wrote:
> On Sun, 16 Feb 2025 at 13:58, Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
> > Reorder functions in drivers/gpio/gpio-aggregator.c to prepare for the
> > configfs-based interface additions in subsequent commits. Arrange the
> > code so that the configfs implementations will appear above the existing
> > sysfs-specific code, since the latter will partly depend on the configfs
> > interface implementations when it starts to expose the settings to
> > configfs.
> >
> > The order in drivers/gpio/gpio-aggregator.c will be as follows:
> >
> > * Basic gpio_aggregator/gpio_aggregator_line representations
> > * Common utility functions
> > * GPIO Forwarder implementations
> > * Configfs interface implementations
> > * Sysfs interface implementations
> > * Platform device implementations
> > * Module init/exit implementations
> >
> > This separate commit ensures a clean diff for the subsequent commits.
> >
> > No functional change.
> >
> > Signed-off-by: Koichiro Den <koichiro.den@xxxxxxxxxxxxx>
> 
> My
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> is still valid.

Thank you, let me add the tag to the two commits in v4 since they remain
unchanged.

Koichiro

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds