Re: [PATCH 00/14] gpiolib: indicate errors in value setters

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Feb 11, 2025 at 1:10 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> The value setter callbacks (both for single and multiple lines) return
> void even though we have many types of controllers that can fail to set
> a line's value: i2c, SPI, USB, etc.

Yeah this is a remnant from the design that was done of gpiolib,
at the time (by David Brownell) assumed to be simple MMIO register
writes, so not much could go wrong there.

> This series proposes to start the process of converting the setters to
> returning int thus making it possible to propagate any errors to the
> user.

My worry is that this project will be another one that stalls at
85% completion (like with the eternal descriptor rewrite project)
but I guess the upside outweighs the downside, and I also trust
your proven grittiness so:

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
for the series +/- minor nitpicks I may send that I am sure
you would address anyway.

Yours,
Linus Walleij