On 22/12/15 16:49, Linus Walleij wrote: > As we want gpio_chip .get() calls to be able to return negative > error codes and propagate to drivers, we need to go over all > drivers and make sure their return values are clamped to [0,1]. > We do this by using the ret = !!(val) design pattern. > > Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > Tomi: as mentioned in 00/54: either apply this directly > or ACK it and I will take it into the GPIO tree. > --- > drivers/video/fbdev/via/via-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/via/via-gpio.c b/drivers/video/fbdev/via/via-gpio.c > index 6f433b8cee12..3d3544036bc1 100644 > --- a/drivers/video/fbdev/via/via-gpio.c > +++ b/drivers/video/fbdev/via/via-gpio.c > @@ -142,7 +142,7 @@ static int via_gpio_get(struct gpio_chip *chip, unsigned int nr) > gpio = cfg->active_gpios[nr]; > reg = via_read_reg(VIASR, gpio->vg_port_index); > spin_unlock_irqrestore(&cfg->vdev->reg_lock, flags); > - return reg & (0x04 << gpio->vg_mask_shift); > + return !!(reg & (0x04 << gpio->vg_mask_shift)); > } Acked-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
