Re: [PATCH] pinctrl: Fix potential NULL pointer dereference

[Markus Elfring <Markus.Elfring@xxxxxx>]

> The `chip.label` could be NULL. Add missing check in the
> rza2_gpio_register().

Another wording suggestion:
The data structure member “chip.label” could become NULL
after a failed devm_kasprintf() call in the implementation
of the function “rza2_gpio_register”.
Thus add a check for such a return value.


How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc2#n145


Can a summary phrase like “Prevent null pointer dereference in rza2_gpio_register()”
be nicer?


> This is similar to commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
> Besides, mediatek_gpio_bank_probe() in drivers/gpio/gpio-mt7621.c also
> has a very similar check.

I find such auxiliary information not so relevant here.

Regards,
Markus