Re: [PATCH 08/54] gpio: lpc32xx: Be sure to clamp return value

[Bjorn Andersson <bjorn@xxxxxxx>]

On Tue 22 Dec 06:13 PST 2015, Linus Walleij wrote:

> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> Cc: Roland Stigge <stigge@xxxxxxxxx>
> Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-lpc32xx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
> index 47e2dde63734..e888b5fcd236 100644
> --- a/drivers/gpio/gpio-lpc32xx.c
> +++ b/drivers/gpio/gpio-lpc32xx.c
> @@ -288,21 +288,21 @@ static int lpc32xx_gpio_get_value_p012(struct gpio_chip *chip, unsigned pin)
>  {
>  	struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
>  
> -	return __get_gpio_state_p012(group, pin);
> +	return !!__get_gpio_state_p012(group, pin);
>  }
>  
>  static int lpc32xx_gpio_get_value_p3(struct gpio_chip *chip, unsigned pin)
>  {
>  	struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
>  
> -	return __get_gpio_state_p3(group, pin);
> +	return !!__get_gpio_state_p3(group, pin);
>  }
>  
>  static int lpc32xx_gpi_get_value(struct gpio_chip *chip, unsigned pin)
>  {
>  	struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
>  
> -	return __get_gpi_state_p3(group, pin);
> +	return !!__get_gpi_state_p3(group, pin);
>  }
>  
>  static int lpc32xx_gpio_dir_output_p012(struct gpio_chip *chip, unsigned pin,
> @@ -364,7 +364,7 @@ static int lpc32xx_gpo_get_value(struct gpio_chip *chip, unsigned pin)
>  {
>  	struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
>  
> -	return __get_gpo_state_p3(group, pin);
> +	return !!__get_gpo_state_p3(group, pin);
>  }
>  
>  static int lpc32xx_gpio_request(struct gpio_chip *chip, unsigned pin)

All of these ends with a "& 1"-operation, so this patch is not needed.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html