Re: [PATCH 27/54] pinctrl: spmi-gpio: Be sure to clamp return value

[Bjorn Andersson <bjorn@xxxxxxx>]

On Tue 22 Dec 06:30 PST 2015, Linus Walleij wrote:

> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> Cc: Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx>
> Cc: Björn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

out_value is a bool, so the patch shouldn't be necessary. But I like
that it's consistent throughout.

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>


On a separate note, I'm not sure that it's correct to update the cached
output value with the current input state here. Need to think a little
bit more on that.

Regards,
Bjorn

> ---
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 3e5ccc76d59c..4460b2c9c8bd 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -533,7 +533,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned pin)
>  		pad->out_value = ret & PMIC_MPP_REG_RT_STS_VAL_MASK;
>  	}
>  
> -	return pad->out_value;
> +	return !!pad->out_value;
>  }
>  
>  static void pmic_gpio_set(struct gpio_chip *chip, unsigned pin, int value)
> -- 
> 2.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html