Re: [PATCH 34/54] blackfin: gpio: Be sure to clamp return value

[Sonic Zhang <sonic.adi@xxxxxxxxx>]

Acked-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>

On Tue, Dec 22, 2015 at 10:38 PM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> Cc: Steven Miao <realmz6@xxxxxxxxx>
> Cc: adi-buildroot-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> Blackfin folks: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
>  arch/blackfin/kernel/bfin_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c
> index a017359c1826..84baa6217c03 100644
> --- a/arch/blackfin/kernel/bfin_gpio.c
> +++ b/arch/blackfin/kernel/bfin_gpio.c
> @@ -1159,7 +1159,7 @@ static int bfin_gpiolib_direction_output(struct gpio_chip *chip, unsigned gpio,
>
>  static int bfin_gpiolib_get_value(struct gpio_chip *chip, unsigned gpio)
>  {
> -       return bfin_gpio_get_value(gpio);
> +       return !!bfin_gpio_get_value(gpio);
>  }
>
>  static void bfin_gpiolib_set_value(struct gpio_chip *chip, unsigned gpio, int value)
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html