Hi, On Thu, Feb 06, 2025 at 10:25:51AM +0100, Linus Walleij wrote: > On Wed, Jan 22, 2025 at 1:05 PM Dmitry Mastykin <mastichi@xxxxxxxxx> wrote: > > > irq_mask()/irq_unmask() are not called for nested interrupts. So level > > interrupts are never masked, chip's interrupt output is not cleared on > > INTCAP or GPIO read, the irq handler is uselessly called again. Nested > > irq handler is not called again, because interrupt reason is cleared by > > its first call. > > /proc/interrupts shows that number of chip's irqs is greater than > > number of nested irqs. > > > > This patch adds masking and unmasking level interrupts inside irq handler. > > > > Signed-off-by: Dmitry Mastykin <mastichi@xxxxxxxxx> > > Patch tentatively applied as non-urgent fix. > > If this is urgent, I need a Fixes: tags and we should also tag it > for stable, is this a big problem for users? I don't have the big picture > here. > > Adding Sebastian, if he's still using this expander. I use the 16 bit I2C version of this chip in the hackerspace together with gpio-keys and haven't noticed any IRQ issues. But the system is running a Debian stable (incl. its kernel), so quite far from mainline :) Greetings, -- Sebastian
Attachment:
signature.asc
Description: PGP signature
