Re: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value_cansleep

[Jonathan Cameron <jic23@xxxxxxxxxx>]

On Fri, 7 Feb 2025 14:13:23 +0200
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Feb 7, 2025 at 12:48 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> >
> > Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> > gpiod_set_array_value().
> >
> > These are not called in an atomic context, so changing to the cansleep
> > variant is fine.  
> 
> ...
> 
> >         if (st->gpio_os) {
> > -               gpiod_set_array_value(st->gpio_os->ndescs,
> > -                                     st->gpio_os->desc, st->gpio_os->info, os);
> > +               gpiod_multi_set_value_cansleep(st->gpio_os, os);
> >         }  
> 
> Now I do not see any justification to leave {}.
> 
With that tidied up (good spot!) if this goes through the GPIO tree
Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>