Re: [PATCH v2 1/2] pinctrl: intel: Import namespace for pwm_lpss function

Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> · Thu, 23 Jan 2025 15:52:06 +0100

Hello Andy,

On Thu, Jan 23, 2025 at 01:45:17PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 23, 2025 at 12:11 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> >
> > The intel pinctrl driver can provide a PWM device and for that needs to
> > call the function devm_pwm_lpss_probe(). That function is provided by
> > the pwm-lpss driver which intends to export it in the "PWM_LPSS"
> > namespace. To prepare fixing the pwm-lpss driver to indeed use the
> > "PWM_LPSS" namespace, import that namespace when used.
> 
> ...
> 
> > +#if IS_REACHABLE(CONFIG_PWM_LPSS)
> 
> > +#endif
> 
> Why?

Because devm_pwm_lpss_probe() is only used #if
IS_REACHABLE(CONFIG_PWM_LPSS). Without the #if but with
https://lore.kernel.org/all/20250123110951.370759-2-u.kleine-koenig@xxxxxxxxxxxx/
this results in a warning (with W=1) :-)

Best regards
Uwe
Attachment:
signature.asc

Description: PGP signature