Re: [PATCH 31/54] pinctrl: sunxi: Be sure to clamp return value

[Chen-Yu Tsai <wens@xxxxxxxx>]

On Tue, Dec 22, 2015 at 10:32 PM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index a437e4f8628b..c53a2dbdb5cf 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -469,7 +469,7 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset)

Above 2 lines:

        val = (readl(pctl->membase + reg) >> index) & DATA_PINS_MASK;

Where DATA_PINS_MASK is 0x01. I think we're covered. But if the !!
design pattern
makes it clearer,

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>

>         if (set_mux)
>                 sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_IRQ);
>
> -       return val;
> +       return !!val;
>  }
>
>  static void sunxi_pinctrl_gpio_set(struct gpio_chip *chip,
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html