Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

[Shree Ramamoorthy <s-ramamoorthy@xxxxxx>]

Hi,

On 1/17/25 3:27 AM, Krzysztof Kozlowski wrote:
> On 16/01/2025 23:38, Shree Ramamoorthy wrote:
>>  /*
>> - * GPIO driver for TI TPS65215/TPS65219 PMICs
>> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
>>   *
>>   * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
>>   */
>> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
>>  };
>>  
>>  static const struct tps65219_chip_data chip_info_table[] = {
>> +	[TPS65214] = {
>> +		.ngpio = 2,
>> +		.offset = 1,
> So that's the same as TPS65215? Why do you keep duplicating entries?

Thanks for reviewing! I will register TPS65214 as "tps65215-gpio" in the
MFD driver to minimize changes. This will eliminate the tps65215 gpio series,
since only the description changes are left.

>> +	},
>>  	[TPS65215] = {
>>  		.ngpio = 2,
>>  		.offset = 1,
> Best regards,
> Krzysztof

-- 
Best,
Shree Ramamoorthy
PMIC Software Engineer