Re: [PATCH v2] pinctrl: bcm63268: add gpio function

[Jonas Gorski <jonas.gorski@xxxxxxxxx>]

Hi,

On Tue, Dec 24, 2024 at 11:41 AM Álvaro Fernández Rojas
<noltari@xxxxxxxxx> wrote:
>
> From: Kyle Hendry <kylehendrydev@xxxxxxxxx>
>
> There is no guarantee that the bootloader will leave the pin configuration
> in a known default state, so pinctrl needs to be explicitly set in some
> cases. This patch adds a gpio function for drivers that need it, i.e.
> gpio-leds.
>
> Signed-off-by: Kyle Hendry <kylehendrydev@xxxxxxxxx>
> Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>


bcm63268-pinctrl implements pinmux_ops::gpio_request_enable(), which
should automatically set any requested GPIO pin to the GPIO function,
so explicitly requesting the gpio function for a pin should not be
needed. Is this not enough?

Best Regards,
Jonas