On 2024/12/24 04:26, Jonathan Cameron wrote: > On Wed, 11 Dec 2024 08:08:05 +0800 > Zijun Hu <zijun_hu@xxxxxxxxxx> wrote: > >> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> >> >> fsl_mc_device_match() does not modify caller's inputs. >> >> Constify it by simply changing its parameter types to const pointer. >> >> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> > Similar to previous patch, I'd say why you are making this change. > There are may places in the kernel where pointers are constant but > not marked so. Why does this one matter? > thank you for code review. make sense. will correct comment message for this and previous patch in v5. > With that info added > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>