Re: [PATCH 2/8] dt-bindings: Add MAX7360 subdevices

["Mathieu Dubois-Briand" <mathieu.dubois-briand@xxxxxxxxxxx>]

On Sat Dec 21, 2024 at 9:34 PM CET, Krzysztof Kozlowski wrote:
> On 19/12/2024 17:21, Mathieu Dubois-Briand wrote:
> > ---
> >  .../devicetree/bindings/gpio/max7360-gpio.yaml     | 96 ++++++++++++++++++++++
> >  .../devicetree/bindings/input/max7360-keypad.yaml  | 67 +++++++++++++++
> >  .../devicetree/bindings/input/max7360-rotary.yaml  | 52 ++++++++++++
> >  .../devicetree/bindings/pwm/max7360-pwm.yaml       | 35 ++++++++
> >  4 files changed, 250 insertions(+)
>
>
> I don't understand how this patchset was split. MFD binding cannot be
> empty and cannot be before child devices.
>

Ok, my bad. So I believe squashing both dt-bindings commit should fix
this.

> > diff --git a/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml b/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml
> > new file mode 100644
> > index 000000000000..3c006dc0380b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml
> > @@ -0,0 +1,96 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/max7360-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Maxim MAX7360 GPIO controller
> > +
> > +maintainers:
> > +  - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
> > +  - Mathieu Dubois-Briand <mathieu.dubois-briand@xxxxxxxxxxx>
> > +
> > +description: |
> > +  Maxim MAX7360 GPIO controller, in MAX7360 MFD
> > +  https://www.analog.com/en/products/max7360.html
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - maxim,max7360-gpio
> > +      - maxim,max7360-gpo
>
> Why? What are the differences?
>

Ok, so maybe my approach here is completely wrong. I'm not sure what
would be the best way to describe the device here, if you have any
suggestion I would be happy to use it. Let me try to summarize the GPIO
setup of the chip.

First we have two series of GPIOs on the chips, which I tend to think
about as two separate "banks". Thus two separate subnodes of the max7360
node.

- On one side we have what I refer to as GPIOs, here with
  maxim,max7360-gpio:
  - PORT0 to PORT7 pins of the chip.
  - Shared with PWM and rotary encoder functionalities. Functionality
    selection can be made independently for each pin. This selection is
    not described here. Runtime will have to ensure the same pin is not
    used by two drivers at the same time. E.g. we cannot have at the
    same time GPIO4 and PWM4.
  - Supports input and interrupts.
  - Outputs may be configured as constant current.
  - 8 GPIOS supported, so ngpios maximum is 8. Thinking about it now, we
    should probably also set minimum to 8, I don't see any reason to
    have ngpios set to something less.

On the other side, we have what I refer to as GPOs, here with
maxim,max7360-gpo compatible:
  - COL2 to COL7 pins of the chip.
  - Shared with the keypad functionality. Selections is made by
    partitioning the pins: first pins for keypad columns, last pins for
    GPOs. Partition is described here by ngpios and on keypad node by
    keypad,num-columns. Runtime will have to ensure values are coherent
    and configure the chip accordingly.
  - Only support outputs.
  - No support for constant current mode.
  - Supports 0 to 6 GPOs, so ngpios maximum is 6.

> > +
> > +  gpio-controller: true
> > +
> > +  "#gpio-cells":
> > +    const: 2
> > +
> > +  ngpios:
> > +    minimum: 0
> > +    maximum: 8
>
> Why this is flexible?
>

I believe this makes sense, as this keypad/gpos partition really changes
the actual number of GPIOS. Yet we could argue that this is just runtime
configuration. Tell me what you think about it, if you think this should
be a fixed value, I will find a way.

>
> Best regards,
> Krzysztof

Thanks a lot for your review. I am preparing a new version of this
series that should address all of your other comments.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com