Re: [PATCH] gpio: generic: clamp values from bgpio_get_set()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Dec 17, 2015 at 2:49 PM, Vladimir Zapolskiy
<vladimir_zapolskiy@xxxxxxxxxx> wrote:
> On 11.12.2015 23:47, Fabio Estevam wrote:
>> Hi Linus,
>>
>> On Fri, Dec 11, 2015 at 7:36 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>> The bgpio_get_set() call should return a value clamped to [0,1],
>>> the current code will return a negative value if reading
>>> bit 31, which turns the value negative as this is a signed value
>>> and thus gets interpreted as an error by the gpiolib core.
>>> Found on the gpio-mxc but applies to any MMIO driver.
>>>
>>> Fixes: b19e7f51a55f "gpio: gpio-generic: add flag to read out output value from reg_set"
>>
>> This commit appeared in 4.2, so it would be nice to add a stable tag:
>>
>> Cc: <stable@xxxxxxxxxxxxxxx> # 4.2+
>
> As it was discussed yesterday in another thread, the specified commit is
> correct, and v4.2 works good.
>
> The problem is in commit e20538b82f1f ("gpio: Propagate errors from
> chip->get()"), which is present in v4.3.
>
> So, Fixes: tag should be removed or corrected IMHO.

OK fixed it, also tagged for stable # 4.3+

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html